rebane2001 / mapartcraft

A Minecraft custom mapart schematica generator, designed to be feasible in survival in servers like 2b2t
GNU General Public License v3.0
237 stars 53 forks source link

1.17 Support: Two New Map Colours #164

Closed Sicarine closed 3 years ago

Sicarine commented 3 years ago

In snapshot 21w15a, as part of the fix for MC-215836, Mojang made Deepslate a different shade from any other shade of gray or dark gray.

Edit: Apparently they also updated the deepslate ore variants to be the same colour as deepslate, distinct from stone

Similarly, in snapshot 21w16a, as a part of the fix for MC-212863, Mojang made Glow Lichen a unique shade distinct from any other similar cyan or aquamarine shades.

See attached screenshot. 2021-04-22_20 40 31

Edit: Checked for changes in 1.17 full release. Deepslate Ore variants are now the same colour as deepslate 2021-06-11_16 57 11

jb2170 commented 3 years ago

Would it be best to let 1.17 mature a couple of minor versions first? 1.16's colours changed a couple of minor versions in ( see #140 )

Sicarine commented 3 years ago

Yea, worth keeping an eye on.

Meanwhile, I'll put a list here for the new 1.17 blocks and what colours they appear to be mapped to. People can check against this list come the next minor release and see if there are any changes:

jb2170 commented 3 years ago

Oh wow that's actually a lot more blocks than I was expecting, exciting stuff. Thank you!

jb2170 commented 3 years ago

I'm noticing Deepslate (and friends) showing up as mapdatId 59 and Glow Lichen as mapdatId 61. I wonder what blocks use id 60 if anything? I created a map with those three at the top, and 60 shows up as the second colour down:

2021-07-10_06 53 57

Trying to create a map with mapdatId > 61 currently (1.17.1) crashes the game, so it seems to be just these new two possibly three colours.

The wiki has not yet been updated for 1.17.

Edit: Background not relevant

crubleigh commented 3 years ago

Color 60 would appear to be compacted raw iron blocks.

jb2170 commented 3 years ago

Ready any time since 2d350f215dc1f3ec4c407448096f4c11100bdc12 . As of writing 2021.07.11 Minecraft is at 1.17.1 and no 1.17.2 is visible. Probably will be deployed soon.

Sicarine commented 3 years ago

Did check it to confirm, and yea. That is the subtlest difference, but it's there. Was that there in 1.17.0, I wonder.... 2021-07-11_16 45 02

Edit: Yep, it was there in the 17.0 release. But so hard to spot.

jb2170 commented 3 years ago

Deployed in 9635ca7995a1d1c78684c069fad78fe4940ca5fa