rebane2001 / matterport-dl

A downloader for matterport virtual tours
The Unlicense
291 stars 73 forks source link

Combined PRs and additional fixes #111

Open mitchcapper opened 2 weeks ago

mitchcapper commented 2 weeks ago

This combines the following:

including many great commits by @flaviozavan, @skashyap7, @ni0ki, @mu-ramadan , @nilpunning, @chadcromwell

all commits were generally left intact so original owners are sighted. @mu-ramadan thanks for something so comprehensive, I did rollback the major changes to whitespace/formatting/line wrapping you added. It makes it very hard otherwise to track history verse the current (and merging some of the older PR a bigger challenge). In terms of line-wrapping editors are far better at line wrapping in most situations and it avoids everyone being forced to a specific column width. I am aware we already wrap the hard coded file lists, but we don't need to wrap so many additional lines.

I still need to fix some of the updates to support all their new measure features and labeling but this seems to be quite comprehensive on the models I have tested so far. There also seems to be an issue hosting on non-standard ports for some reason.

I will remove the JS please post a bug message as well the brute option should catch all.

chadcromwell commented 2 weeks ago

👍

rebane2001 commented 2 weeks ago

Haven't tested, but LGTM otherwise. Feel free to merge when ready.

mitchcapper commented 2 weeks ago

Yeah I plan to fix the few remaining things and do several more test runs this weekend. I need a reinvite to the org I didn't accept in time last time.

rebane2001 commented 2 weeks ago

Sent invite

mitchcapper commented 6 days ago

beware this slightly broken now, if doing later runs as the key expires will be updating further but this is to get some newer models to give us the data.

mitchcapper commented 2 days ago

Sorry I have greatly increased the scope of this PR. I figured if there were some vast changes that everyone should test might as well make them all at once. I got most of the backlog of items on my todo for it done.

The major items include:

Have not tested back-compat with old downloads thoroughly but seems to work fine.

Still need to properly open tileset model files(glb) in binary form and be able to still regex search them without having to re-download each time

The one commit I have not done but will do so right before committing to trunk is formatting. I already committed a pyproject and vsworkspace files up to enable ruff formatting. It should avoid massive format only changes in the future by standardizing everything but has the one time cost of format updates. You can run the formatter yourself to preview, I mostly emulated the style we already used, but didn't want it further cluttering this PR up.

Overall please test find models that are broken.

I am excited about the potential future of the proxy script. Two big things:

  1. restore the ability to host models on standard web servers without any fancy rules. It can change post request to get, and redirect things as we want so could make that a very real possibility
  2. Future compatibility fixes and query updates could be (mostly) automated. It can be injected into the live site and log all things to a local service in the future to avoid us having to figure out what is different manually.