search

rebane2001 / matterport-dl

A downloader for matterport virtual tours
The Unlicense
322 stars 79 forks source link

Excessive DNS requests #28

Closed Slyke closed 2 years ago

Slyke commented 2 years ago

When I run this, PiHole is complaining that my computer has been making too many DNS requests (default limit is 1000 in a 60 second time period). Setting my computer's DNS to some public one like 8.8.8.8 and bypassing PiHole mitigates this issue, but is it possible to have the Requests module cache matterport's IP address?

mitchcapper commented 2 years ago

generally your computer (or at least windows) and your dns server should both be caching the DNS information unless the record itself has a TTL that is very short.

In terms of the request this is beyond this project scope it would fall to the requests module which already says won't fix: https://github.com/psf/requests/issues/1453 followed by urllib3 saying the same: https://github.com/urllib3/urllib3/issues/925

Slyke commented 2 years ago

Ah, okay! Fair enough. Thanks for answering!