search

rebassjs / grid

This package has moved and renamed
https://rebassjs.org/reflexbox
MIT License
2.04k stars 96 forks source link

Update to fix compatibility with emotion 10 #162

Closed SimeonC closed 5 years ago

SimeonC commented 5 years ago

Emotion 10 also have renamed their packages. Creating two exports so there is still backwards compatibility if needed.

I figured as we have a major version in the works here we should keep the emotion export as 10 instead of doing grid/emotion10 and grid/emotion9 as the 9 export will eventually go away.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

SimeonC commented 5 years ago

@jxnblk Can you help shed some light onto why Travis doesn't pass? First off it complained about package-lock being different now it has some obscure sha error? Tests and build pass on my local machine.

jxnblk commented 5 years ago

Thanks! Not sure why the CI is failing, but looks like it might be related to the lock file – not sure if you wanna try undoing that change and running npm i --package-lock-only to see if it helps – otherwise I can try on another branch later.

It might make sense to remove all the peer dependencies in this PR as well, see #157

SimeonC commented 5 years ago

@jxnblk Thanks for the tip, I tried that but it didn't change the package-lock file. I didn't remove the peerDependencies as it would have conflicted with https://github.com/rebassjs/grid/pull/158 I can just remove any changes to the peerDependencies then it won't conflict?

jxnblk commented 5 years ago

Oh, missed the other PR, sorry. I'll get that merged in first. But yeah, other than doing git checkout package-lock.json to reset it, I'm not sure what else to advise

jxnblk commented 5 years ago

I branched off of this one to try reseting the lock file and it seems to pass in travis now, see this branch for comparison https://github.com/rebassjs/grid/tree/SimeonC-emotion-fix-lock-file

SimeonC commented 5 years ago

Hmmm, I must be running a different version of node/npm - I don't know what version travis is using. What version of node/npm are you using? If that's the case I'll add a .nvmrc file that should help alleviate those kinds of issues.

EDIT: As an aside I don't mind if you manually merge in with the correct package-lock and close this PR.

jxnblk commented 5 years ago

I'd like to have your contribution in here if possible, but also wanna make sure that contributing to this project works as expected. I don't think an .nvmrc file really should be necessary, but this project should work with Node 10 and npm 6

SimeonC commented 5 years ago

OK, I'm on Node 8 and npm 6 as well so there shouldn't be any problems. This time I tried deleting node_modules and package-lock and that seems to have worked so I think I may have just installed it the first time pointing at my companies private npm instead of the public one or something.