search

rebassjs / rebass

:atom_symbol: React primitive UI components built with styled-system.
https://rebassjs.org
MIT License
7.94k stars 656 forks source link

Checkbox component is broken with styled-components v5x.x #1049

Open javiercr opened 3 years ago

javiercr commented 3 years ago

Hi,

We've upgraded our project from styled-components v4 to v5 and we've noticed that the rebass Checkbox form is now broken: the checkbox icon doesn't render when the checkbox is checked, it only renders properly when is disabled.

Here is a repro: with styled-components v4 (everything works fine) https://codesandbox.io/s/elastic-water-h1rg6

with styled-components v5 (Checkbox broken) https://codesandbox.io/s/gallant-heyrovsky-cxbc0

I've taken a look to the styled-components changelog but haven't found anything change that I could associate with the described problem.

PS: thank you for rebass, it's an amazing library :)

javiercr commented 3 years ago

Apparently the same problem applies to <Radio>. It seems to be related to https://github.com/styled-components/styled-components/issues/3265.

There is a workaround suggested on https://github.com/styled-components/styled-components/issues/3244#issuecomment-687676703 that seems to work.

I'll open a PR with that fix.

evenromo commented 3 years ago

Where are we on this one? Would be nice to have the fix merged

anvitrola commented 3 years ago

Where are we on this one? Would be nice to have the fix merged I'm having the same issue :/ it would be very nice to have it fixed