rebelot / kanagawa.nvim

NeoVim dark colorscheme inspired by the colors of the famous painting by Katsushika Hokusai.
MIT License
4.25k stars 180 forks source link

Certain orange shades aren't appearing properly #133

Open evanrittenhouse opened 1 year ago

evanrittenhouse commented 1 year ago

Sorry that the title is a bit vague, I'm not sure what could've happened. I didn't make any changes on my end, but all of a sudden certain oranges appear incorrect. For example, the README shows a specific shade of orange for crate imports.

My system is shown below. I've tried set termguicolors and set notermguicolors, and I've successfully replicated the issue outside of Tmux. I've also uninstalled/reinstalled Kanagawa in hopes that that could fix it, but again, no dice.

image

Thanks for making such an awesome colorscheme! Looking forward to getting this sorted back out.

rebelot commented 1 year ago

Yep, it definitely looks off.

Does it look "right" with other file types? Is treesitter enabled? Do you use any plugin that could interfere with highlights? (Maybe some changes in rust-tools)?

Edit: use :Inspect command to get some info on the hlgroup used to highlight certain elements

evanrittenhouse commented 1 year ago

So this is what it looks like with the Rust Treesitter parser installed (previously, I don't think it was. Still some weird highlight colors, specifically parameter names, macros, and crates). image

I also don't use rust-tools, instead I've got a vanilla rust-analyzer setup through nvim-lsp. I'll start trying to disable plugins one by one tonight and see if that gets me anywhere, then report back.

I'm also getting a Not an editor command: Inspect when I try to run :Inspect, but I got some stuff under :highlight. What should I be looking for? One thing I noticed: Macro xxx links to PreProc where PreProc is PreProc xxx guifg=#e46876, which I believe is unexpected.

evanrittenhouse commented 1 year ago

Update: I couldn't find a plugin which affected the colors, from what I could tell

evanrittenhouse commented 1 year ago

@rebelot I upgraded to 0.9 and got access to Inspect.

Inspecting #[violation] gives

Treesitter
@variable.rust linkes to @variable rust
@function.macro.rust links to PreProc rust

Semantic Tokens
- @lsp.type.decorator.rust links to Function priority: 125
- @lsp.mod.attribute.rust links to @lsp priority: 126
- @lsp.mod.library.rust links to @lsp priority: 126
- @lsp.typemod.decorator.attribute.rust links to @lsp priority: 127
- @lsp.typemod.decorator.library.rust links to @lsp priority: 127

Inspecting one of the crate imports (regex, line 5) gives

Treesitter
@variable.rust links to @variable rust
@namespace.rust links to Identifier rust

Semantic Tokens
- @lsp.type.namespace.rust links to Identifier priority: 125
- @lsp.mod.crateRoot.rust links to @lsp priority: 126
- @lsp.mod.library.rust links to @lsp priority: 126
- @lsp.typemod.namespace.crateRoot.rust links to @lsp priority: 127
- @lsp.typemod.namespace.library.root links to @lsp priority: 127

It also seems like assert/assert_eq! macros link to @exception.

rebelot commented 1 year ago

what is it that doesn't feel right to you? It seems that after you enabled TS highlights colors look as expected

evanrittenhouse commented 1 year ago

Ah, just thought for example assert!() used to be orange. No problem - feel free to close