rebelot / kanagawa.nvim

NeoVim dark colorscheme inspired by the colors of the famous painting by Katsushika Hokusai.
MIT License
4.26k stars 180 forks source link

Add support for split borders #38

Closed ihasdapie closed 2 years ago

ihasdapie commented 2 years ago

With https://github.com/neovim/neovim/pull/17266 being merged in it would be nice to have better highlights and drawing characters for splits.

This is what kanagawa looks like right now image

As opposed to another colorscheme which implements it e.g. gruvbox or catppuccin image

rebelot commented 2 years ago

Yup, I was playing with this today. I will add a globalStatus bool option to control the highlighting of window separator. I'll see wether it's best to also add fillchars presets or not.

It would be great to have WinSeparatorNC to complement with NormalNC tho

rebelot commented 2 years ago

it's now supported as of 42584e5

kting28 commented 1 year ago

Hi I'm looking at enabling the split border but this globalStatus option is no longer there. What's the latest way of making the split separator more visible?

rebelot commented 1 year ago

You can use thicker 'fillchars', or change their color to your liking, e.g.

            require("kanagawa").setup({
                overrides = function(colors)
                    local theme = colors.theme
                    return {
                        WinSeparator = { fg = theme.ui.nontext }, -- brighter
                        WinSeparator = { fg = "black" }, -- darker
                    }
                end,
            })
kting28 commented 1 year ago

Awesome thanks! Just another question - this changes the color of the active win separator. How about the inactive one? (i.e. in horizontal split when the lower is active and upper bar is inactive). Want to see where to override to make that lighter. Thanks.

rebelot commented 1 year ago

Awesome thanks! Just another question - this changes the color of the active win separator. How about the inactive one? (i.e. in horizontal split when the lower is active and upper bar is inactive). Want to see where to override to make that lighter. Thanks.

there's no such hlgroup. The closest thing to that would be using dimInactive, This is the default value for WinSeparator taking dimInactive option into account

        WinSeparator = { fg = theme.ui.bg_m3, bg = config.dimInactive and theme.ui.bg_dim or "NONE" },
kting28 commented 1 year ago

For me it seems dimInactive is flipped as in the dimmed split actually got highlighted due to the higher contrast (the bg got darker while text is the same ). Will mess around to see if I can flip it.