search

rebels2638 / FRC-2023-Beta-Testing

Beta testing environment for FRC 2023 challenge.
0 stars 5 forks source link

Seperating VisionOdometry subsystem out from ChaseTag.java #12

Open KryptoCrash opened 1 year ago

KryptoCrash commented 1 year ago

Please create a new subsystem for VisionOdometry that has functions to get target Pose, robot Pose, etc. Then use those functions inside of ChaseTag.java instead.

KryptoCrash commented 1 year ago

Also please comment your code

KryptoCrash commented 1 year ago

It also looks like https://github.com/rebels2638/FRC-2023-Beta-Testing/blob/cd1f55423edc91c44260993358ec24aa79403399/src/main/java/frc/robot/commands/ChaseTag.java#L105 is only usable for swerve drive. We need to replace this with a RamseteController probably.