rebinf / QuranVideoMaker

A video editor with the emphasis on creating Quran translation videos.
Other
27 stars 7 forks source link

Can't edit each individual verse #71

Closed Farfighters closed 5 days ago

Farfighters commented 5 days ago

Normally you can double click the verse and a pop up comes up that allows you to edit the verse fully, deleting certain parts or adding more. But for some reason now if I change it, it is not updating as shown: image image Maybe another feature that would be very useful is adding an 'empty' verse where you can add whatever you want into it, maybe it could be adhkar etc as well. You could have option to add more textboxes (normally you have 1 and if you want to put translation for example you add into new box that comes up separately as it does already). I will make new issue and add this there. Jazakhallah khair

Farfighters commented 5 days ago

Assalamualaikum wbt, jazakhallah khair for implementing the features I asked for so quickly! Just confirming that this hasn't been done yet, right? For some reason, when I export as verses (new feature), it shows up as the modified one, it's just a visual thing. But it is still important to be able to see it visually so it is easier to edit and know whether it has been modified or not inshallah.

rebinf commented 5 days ago

wa alaykum salam, this is due rendered verse cache not being cleared after change. I've fixed it, it should be available in a few minutes inShaAllah.

Farfighters commented 5 days ago

Ah ok, jazakhallah khair

Farfighters commented 4 days ago

Assalamualaikum wbt, for some reason it is still playing up. If I copy the same verse let's say 5 times, after changing the first one, the rest look the same, even if it has been changes. Must be the same issue as before, maybe it is not clearing because I have made so many? image

rebinf commented 4 days ago

wa alaykum salam, this is due to incorrect cache clearing, which should now be fully resolved in the latest update.

Farfighters commented 4 days ago

I was testing this and now if I copy and paste first time, the second one is fine. If I paste it again, the 3rd one is still not showing up. But if I copy again then paste it, then it is fine. Essentially you need to copy then paste every time for it to work, you can't just keep pasting. This is fine though, it is working better now.

rebinf commented 4 days ago

Thanks for reporting this, I think it should be working as expected now.