EwanC
commented
1 year ago As part of #174 some reduction tests have been added, the explicit ones have been marked as XFAIL. As part of actioning this ticket, all these tests should be reliable passes.
Explicit/dotp_buffer_reduction.cpp
Explicit/dotp_usm_reduction.cpp
Explicit/sub_graph_reduction.cpp
RecordReplay/dotp_buffer_reduction.cpp
RecordReplay/dotp_usm_reduction.cpp
RecordReplay/sub_graph_reduction.cpp
Reductions currently have several issues in graphs, though they work in some limited cases (where the device supports USM and it happens through record and replay) but there are issues particularly in explicit mode (reduction code expects a device in the handler). These should be addressed for both modes and with buffers and USM.
Accessor support was added in #151 which should help with this issue.
Note: Buffers may be hard to test if we can't force reductions to use them.