search

reblws / tab-search

WebExtension for keyboard-accessible tab management
https://addons.mozilla.org/en-US/firefox/addon/tab_search/
MIT License
127 stars 18 forks source link

Add mouse interface for tab management #47

Open whiskytroll opened 6 years ago

whiskytroll commented 6 years ago

In the options it's stated that you have added "More tab management options". Am I right when I believe those are the ones mentioned in issue "Tab management #31"?

There these features where discussed:

Move tabs Refresh tabs Mute/Unmute tabs Pin tabs Copy the url of the selected tab(s) Bookmark selected tab(s) Close duplicated tabs Move selected tab(s) to an existing window/new window

The issue was edited as Done for release 0.4 and I have 0.4.4, but I still can't find the features. Some of them would be very useful indeed!

I'm on Ff Quantum 58.0.2 (64-bit) branded as Mozilla Firefox for Linux Mint mint-1.0, on a machine with Linux Mint 18.3 Cinnamon.

reblws commented 6 years ago

Hi have you pressed the triple dot menu icon next to the search input? That takes you to the settings page where you can modify and see what the keyboard shortcuts for managing tabs are.

There isn't a way to activate most of them with the mouse and that's something I'm looking to improve in future releases.

reblws commented 6 years ago

If you have any suggestions for how for how the default shortcuts could be improved, I'm happy to hear them.

whiskytroll commented 6 years ago

Ahh, ok. That explains it. I have trouble remembering shortcuts (but for a very few that I use very often), so I didn't even look at them. Sorry to waste your time with that. (I see however that not all in the list I referred to is implemented, will they be sometime in the future or are you content? Move tabs, bookmark tabs and move to new window isn't in the list of shortcuts, and I'm particularly interested in how to move tabs.)

I'm looking forward to the day that you have released a version with more mouse support. I realize that shortcuts are more efficient, but I'd have to remember them for that to happen... If you are interested in discussing exactly how that would be implemented I'd be happy to give feedback. (However I can't help much with coding. I have only the faintest idea of C and python so I would probably be more of a hindrance.)

I'd love to help you, but I believe it's for the best if I don't. Not using shortcuts very much should make me just short of useless in giving advice about them. I'm sure your defaults are excellent, your extension does give the impression of being very well thought through in general.

reblws commented 6 years ago

Hah, no time wasted! I'm happy that people are using this extension in ways I didn't originally intend and getting feedback based on that. Getting valuable user-feedback like this actually helps a lot.

If you'd like to help with development I'd be more than happy to explain how things work depending on what you'd like to change.

Right now the tab list generation is handled by createTabObject in https://github.com/reblws/tab-search/blob/master/src/core/pages/popup/utils/dom.js#L161. It's written in imperative JavaScript and might not be the easiest to understand at the moment.

If you're interested in helping more I can provide more instructions and a basic HTML and CSS template of the tab-list that you can modify and improve.