rebo / atomic_hooks

4 stars 6 forks source link

Add documentation for reactive state access #3

Closed arn-the-long-beard closed 4 years ago

arn-the-long-beard commented 4 years ago

Hello !

I opened an issue https://github.com/rebo/atomic_hooks/issues because I want to help.

rebo commented 4 years ago

Great work, keep going on this everything is helpful.

Let me know when you are ready to merge and I will merge. 👍

arn-the-long-beard commented 4 years ago

Thank you for your message !

Yes i will let you know :+1:

arn-the-long-beard commented 4 years ago

I made a comment because I found something strange regarding the global_undo_queue().travel_backwards()

I did pushed an example of the maybe bug withb(),get()

arn-the-long-beard commented 4 years ago

I see that we do not have impl<T> ObserveChangeReactiveState<T> for AtomUndo<T>

There are few docs I could add about CloneReactiveState and others. I will do that later after refactorisation.

arn-the-long-beard commented 4 years ago

I have some issue to rebase. I think it might be because I did not created a new branch on my project and I made the changes directly on my master. I am trying to find a solution for it to solve the conflict.

arn-the-long-beard commented 4 years ago

Okay, Github is awesome. I fixed the stuff I think.