Refactoring/reactive state access

rebo / atomic_hooks

4 stars 6 forks source link

Closed arn-the-long-beard closed 4 years ago

arn-the-long-beard commented 4 years ago

Hello :smiley:

This step is about making the code for reactive_state_access a bit more beautiful and raffinate the nice work from @rebo

[x] Divide reactive_state_access into files with their dedicated impl & struct for atom,atom_undo & reaction.
[x] Update import from these file.
[x] Distribute the unit test for each of those concept into their respective files
[x] Look into naming maybe and see if we can improve there as well.

arn-the-long-beard commented 4 years ago

I saw there are impl for atom , atom_undo & reaction in observable.rs. It did made the import a bit complex by the way :stuck_out_tongue:

Should they stay there or should we move them where their struct are defined? I am not sure about the best practice there.