search

rebo / seed_styling_app

0 stars 1 forks source link

Remaining Issues from Style Feedback #6

Open rebo opened 4 years ago

rebo commented 4 years ago

Previous issue #3 closed with several fixes, these are the remaining ones:

Feedback for Seed Style (https://seed-style-hooks.netlify.app/style_home).

  • [x] 0) I think I saw some typos but it should be much better than my seed-rs.org docs.. 😺

  • [ ] 6) I was a bit confused because of many (glob) imports - which libraries are imported and required and where I can find seed_style, seed_colors, theme, etc.. and what rules should I respect to not cause panics in runtime. Especially when rust-analyzer doesn't work. Perhaps just a beginner problem, but I had an impression that there are too many moving parts.

  • [ ] 10) s(). vs S.. It's probably the most important thing to resolve before we can integrate Seed Style into Seed. So.. why s(). and not S.?

  • [ ] 11) Why I had to call .breakpoint_scale([600, 960, 1280, 1920]) (https://seed-style-hooks.netlify.app/responsive_styling)?

  • [ ] 12)

           Msg::WindowResized => {
          conditionally_skip_rendering::<Breakpoint, _, _, _>(|| default_bp_theme(), orders)
      }

    looks pretty cumbersome and I assume that conditionally_skip_rendering is imported by glob so it pollutes API surface and I don't have an idea where it's defined. Possible alternative - the first idea:

          Msg::WindowResized => {
          if not(S::breakpoint(default_bp_theme()).has_changed()) { orders.skip(); }
      }

  • [ ] 13) It would be nice to see the code snippet corresponding to the example - https://seed-style-hooks.netlify.app/layout

  • [ ] 14) There are missing links to the repo and for feedback - something like the footer in https://seed-rs.org/. Also I don't see a link to seed-rs.org.

rebo commented 4 years ago

From Discord:

  1. is a theme is swapped is -> if https://seed-style-hooks.netlify.app/theming

Fixed

  1. customisatble https://seed-style-hooks.netlify.app/hooks_getting_started

Fixed

  1. ? the initial render line the -> The https://seed-style-hooks.netlify.app/hooks_getting_started

Fixed

  1. useful to create have components extra create or have https://seed-style-hooks.netlify.app/hooks_getting_started

Fixed

  1. Bullet list under That said there are some circumstances where the monolithic is badly formatted https://seed-style-hooks.netlify.app/hooks_getting_started

Fixed

  1. three principles atoms, reactions and observations. - perhaps we should add : - principles:

Fixed

  1. Bullet lists in https://seed-style-hooks.netlify.app/hooks_tutorial are also badly formatted - probably all ones (?)

Fixed