rebootcode / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
0 stars 0 forks source link

Flyout menus stuck partially open #856

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Hold down the mouse button on a flyout to start expanding it.
2. When it is partly expanded, release the mouse and press again.

What is the expected output? What do you see instead?
The flyout should fly out just as if it weren't already doing so. Instead it 
will start flying out but stop flying once it reaches wherever it was when you 
interrupted it.

For example, if you did the release-and-repress when the rect flyout was 
showing one and a half buttons, it will never again fully expand itself out 
fully to show all three buttons that it ought to until you refresh the page.

I got this to happen in Chrome and Firefox. It can take a few tries to get the 
timing just right.

This happens because the mousedown handler reads the flyout's current left 
position and uses it as the target for flying towards. That doesn't do the 
right thing if the left attribute is being animated.

A fix is to store the correct position in scope and just reference that instead 
of checking the current left. I'm attaching a patch that does this. It seems 
like a pretty benign change, so I'll just commit it in a few days if no one 
objects, but I don't want to just unilaterally commit something.

Original issue reported on code.google.com by peter.d....@gmail.com on 19 Sep 2011 at 1:14

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in r2042.

Original comment by peter.d....@gmail.com on 24 Sep 2011 at 11:40