search

rebootcode / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
0 stars 0 forks source link

Gradients go black in webkit browsers on resize of imported imaged once link to reference element is broken #858

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Import a symbol from the IAN library (I think all, but mostly tested with 
Birds > Aegolius acadicus)
2. Break link
3. Resize

What is the expected output? What do you see instead?
All gradients go black.

Please use labels and text to provide additional information.
This is a regression starting at r1969

Original issue reported on code.google.com by adrianbj...@gmail.com on 23 Sep 2011 at 5:57

GoogleCodeExporter commented 9 years ago 
It seems this can be fixed by removing switch statement that was added in r1969 
described as:

// If it still has a single [M] or [R][M], return null too (prevents 
BatchCommand from being returned)

Not sure if this is still needed as I think the undo weirdness described in 
Issue 662 still seems to be fixed, but maybe I am missing something in my 
testing.

Anyone see any issues with removing this code from the trunk?

Original comment by adrianbj...@gmail.com on 25 Sep 2011 at 6:19

GoogleCodeExporter commented 9 years ago 
Unfortunately this "fix" seems to adversely affect other gradient issues. 
Breaking link has always changed gradients slightly (Issue 469), but without 
this switch statement, the changes to gradients are much worse. Better than 
going completely black, but still not really acceptable. An even better example 
is IAN > Birds > Aptenodytes forsteri (Emperor Penguin)

Original comment by adrianbj...@gmail.com on 25 Sep 2011 at 6:48

GoogleCodeExporter commented 9 years ago 
Moving all open import issues to 2.7 milestone.

Original comment by asyazwan on 26 Mar 2012 at 7:32

GoogleCodeExporter commented 9 years ago 
Seems like removing that switch is now working fairly well in the latest 
version of Chrome 21.0.1180.89. With that switch removed, you can now break 
link  and move the image around - doesn't go black until you rotate it.

Original comment by adrianbj...@gmail.com on 7 Sep 2012 at 6:17

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Just to keep this issue updated, the switch statement referenced in comment#1 
is now in recalculate.js. Removing still results in the same improvements as 
before - ie you can break link to reference element and gradients are 
maintained (not black), until the element is rotated.

Original comment by adrianbj...@gmail.com on 8 Mar 2013 at 3:44

GoogleCodeExporter commented 9 years ago

Original comment by bret...@gmail.com on 7 Apr 2014 at 3:38

GoogleCodeExporter commented 9 years ago

Original comment by bret...@gmail.com on 7 Apr 2014 at 3:45