Enable drag and drop import

rebootcode / svg-edit

Automatically exported from code.google.com/p/svg-edit

MIT License

0 stars 0 forks source link

Enable drag and drop import #999

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

This is a patch that enables drag and drop import of any image (svg, jpg, gif, 
png) into svg edit's canvas. It also enables SVG to import bitmaps through the 
menu "Import SVG..." so I've changed the title to "Import Image...".

Original issue reported on code.google.com by duopi...@gmail.com on 11 Aug 2012 at 1:11

Attachments:

drag-import.diff

GoogleCodeExporter commented 9 years ago

Hi Mark,

The patch looks good overall, I'll test and commit when I have the chance (my 
dev box). Otherwise other committers are welcomed to do so.

Thanks!

ps. I also hate how we need to initialize dummy image to get the dimension. 
Although in your case it's unnecessary to actually append it to the document. I 
managed to do it in-memory.

Original comment by asyazwan on 11 Aug 2012 at 7:56

Changed state: Accepted
Added labels: NeededFor-2.7

GoogleCodeExporter commented 9 years ago

Any news on this?

Thanks!

Original comment by marclaporte on 21 Oct 2012 at 6:36

GoogleCodeExporter commented 9 years ago

Committed in r2090. Thanks for reminding.

Original comment by asyazwan on 22 Oct 2012 at 10:50

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

I really like the idea of drag&drop, but is this fix 100% stable? It seems to 
only work sometimes. In fact, I have only been able to get it to work once on 
the latest updated trunk. Any tips?

Original comment by babyboyb...@gmail.com on 24 Oct 2012 at 9:53

GoogleCodeExporter commented 9 years ago

Which browser?

When it doesn't work, does it fail silently or something bad happen? (ex.: lost 
data)

Original comment by marclaporte on 24 Oct 2012 at 11:42

GoogleCodeExporter commented 9 years ago

Instruction to reproduce your bug would be great. As far as this patch is 
concerned, it's used in Submitter's production code. It didn't break any 
existing tests, and it worked as advertised when I tested it on Chrome. The 
things I slightly changed in the commit doesn't sound like probable cause of 
this.

Original comment by asyazwan on 24 Oct 2012 at 1:52

Changed state: NeedsInfo

GoogleCodeExporter commented 9 years ago

Hi Mark,

thanks for your great drag and drop feature.
It works fine for me in FF and Chrome, but somehow in IE9 if I drag and drop an 
image into the svg-edit the image doesn't drop. Instead it is just displayed as 
single image in the browser tab.

Original comment by michael....@gmail.com on 14 Dec 2012 at 9:28

GoogleCodeExporter commented 9 years ago

IE9 does not support Drag and Drop, IE10 might support it but I haven't tested 
it yet.

Original comment by duopi...@gmail.com on 14 Dec 2012 at 2:37

GoogleCodeExporter commented 9 years ago

Since no feedback has been provided by #4, I'm closing this issue.

Issue a new ticket if you have problems with drag & drop.

Original comment by asyazwan on 21 Feb 2013 at 5:01

Changed state: Fixed