Closed spicycode closed 7 years ago
@fifthbymidwest I'm working through issues with Travis setup now, but that should be the final piece.
Everything is passing now. Pending your review this is good to merge from my end. (The build failing badge is because master is failing).
With this PR all issues with running tests locally are resolved. Hopefully so for TravisCI as well.
I'll outline the changes I did below.
rspec-rails
instead ofrspec
for Rails projects. See https://github.com/rspec/rspec-rails#installation for details.rspec-rails
is in the Gemfile vsrspec
. The command I ran wasrails generate rspec:install
.rails_helper
, notspec_helper
. At some point in recent RSpec versionsrails_helper
became the default require in test files.spec_helper
is required byrails_helper
.expect
syntax (should
syntax is deprecated, but still works).