search

reborndb / reborn

Distributed database fully compatible with redis protocol
MIT License
898 stars 142 forks source link

fix redis config MAXMEMORY to lowercase #135

Closed neilss closed 9 years ago

neilss commented 9 years ago

In auto-rebalance process, get null for config "MAXMEMORY", which will cause paserInt error, then rebalance process stop for the error. The correct config is lowercase 'maxmemory'

qiuyesuifeng commented 9 years ago

LGTM. Yes, it is a problem. Btw, for reborn rebalance feature, now we only using redis maxmemory to do it. Actually, it is not a good method, we may redesign it later. Same problem also exist if u use our qdb(https://github.com/reborndb/qdb) as storage, for qdb use rocksdb and it is not only use memory but also disk.

neilss commented 9 years ago

I just test the rebalance function. Here is my issue https://github.com/reborndb/reborn/issues/134 Is this normal for cost about 15 minutes to rebalance 1024 keys in 3 groups?