search

reboundjs / rebound

Automatic data binding for backbone using HTMLBars.
MIT License
43 stars 4 forks source link

Static error in module body #24

Closed matthewrobb closed 10 years ago

matthewrobb commented 10 years ago

epicmiller/rebound/lib/rebound/components/model.js#L62

Backbone.Model.prototype.set = function(key, val, options){
  var attrs, val, newKey;

This is fine when using the old es6-module-transpiler because it's not very strict. The problem is not only do module bodies generally get wrapped in a strict-mode iife the transpiler alo asserts on some static errors. In the above you cannot redeclare val since it has a named parameter of val.

amiller-gh commented 10 years ago

I've got a bit jshint commit I'm pushing out today, just added it to the grunt build step and fixed all the silly errors like that one above that came up.

amiller-gh commented 10 years ago

Also coming in this push, after I fix one more bug with it, is the Polymer custom-element and mutationOvserver shims. I've re-worked it to work with the proper custom-element registration syntax.