reboundjs / rebound

Automatic data binding for backbone using HTMLBars.
MIT License
43 stars 4 forks source link

Computed Property Re-Write. #36

Closed amiller-gh closed 9 years ago

amiller-gh commented 9 years ago

I'll add the /dist directory to the gitignore file after this commit. Only things in /packages and /test are applicable.

jamesplease commented 9 years ago

If you wanted to remove the dist folder for this commit to make this PR a bit more reviewable, you could update your gitignore locally, then run:

# recursively remove all files from the git cache
git rm -r --cached .
# add em back
git add .
amiller-gh commented 9 years ago

1 sec, I'll fix it. I think that will still show all the files removed in the diff, it won't be much more legible. I'll reset the dist file to what is currently checked into master and push without compiling them again

jamesplease commented 9 years ago

I think that will still show all the files removed in the diff, it won't be much more legible

Ah, right, good point. Maybe using 2 commits here would be a good idea: the first could remove the dist directory from the repository, and the second to add the relevant changes.

amiller-gh commented 9 years ago

There ya go :)