search

rebtd7 / FF13Fix

Performance and bug fixes for the PC versions of FF13 and FF13-2
GNU General Public License v3.0
329 stars 22 forks source link

[FF13] Allow usage of 4GB memory patch #52

Closed rebtd7 closed 3 years ago

rebtd7 commented 3 years ago

The idea of patching CreateFileA came from reading the README from "4GB Fallout New Vegas Updated" mod by "MonochromeWench - Hendricks266 - Roy Batty".

The idea is to revert back the changes of the Large Address Aware patch so it passes the integrity check. The file integrity check is bypassed by redirecting to an unmodified file.

Seems to work fine, but I've only experimented a little bit. I don't know if the game itself can properly handle 2GB+ addresses. Needs experimentation, I suppose.

Fixes #48

Nucleoprotein commented 3 years ago

Look good but what about FF13-2?

rebtd7 commented 3 years ago

It doesn't seem the executable file integrity is checked for FF13-2 (neither in RAM or in the HDD), so we don't really need to do anything (the executable file just needs to be patched with an external tool)

The README contains instructions on how to patch both games; let me know if you think it is not clear enough (or feel free to edit)

mbort commented 3 years ago

I'd like your permission to include a copy of the FF13Fix in a couple of the FF13 mods on Nexusmods (The FF XIII HD Project for example https://www.nexusmods.com/finalfantasy13/mods/17 ) This mod runs up against the 2GB memory limit and does crash for some people (and I've omitted some upscaled textures as well). My intent would be to not only include this fix, but automatically install it during my install process (assuming they don't already have it or have an older version) and enable the 4GB memory patch as well. Let me know if you are OK with this. Thanks.

rebtd7 commented 3 years ago

@mbort I have mixed felling about this. I'd rather you to just link here... Perhaps check if the user have installed and link to this site so they can download it?

My reasoning: First I'd rather have none of my mods added to NexusMods, as I've been burned by them before.. I assume you wouldn't feel great either if someone repacked your mod, did not credit you, and your reports/comments were simply ignored or deleted... I don't think having a closed, centralized entity controlling and profiting on the mods is in the best interest of the gaming community.

Second, is that unless you are updating the mod on every single release of FF13Fix you will inevitably have outdated versions of the mod which may cause issues that are already fixed here.

That said, I think the current situation is awful: It is too much trouble to run the games, and the instructions are complicated (specially for people with little experience in tinkering with computers). I think the ideal situation would be someone creating a open source mod manager/installer (perhaps something like 7th heaven for FF7?) that can download the mods the user wants instead of bundling all the mods together

You can include a copy of FF13Fix if you want: the license allows you do to so, and I certainly won't be mad, but my personal preference is that you simply link here (or create said mod manager :grin:)

rebtd7 commented 3 years ago

@Nucleoprotein it's your code too, fell free to give your opinion on the matter

mbort commented 3 years ago

Fair enough. I've been burned before with my mods showing up elsewhere. The only thing I disagree with is that maybe you should look into creating the mod manger. After all, it's your idea 😉

rebtd7 commented 3 years ago

@mbort I don't really have much time to invest in this project unfortunately

Honestly, if you think bundling FF13Fix in your mod is the best for the end user, feel free to do so (just credit and provide the source code to comply with the license)