search

rebtd7 / FF13Fix

Performance and bug fixes for the PC versions of FF13 and FF13-2
GNU General Public License v3.0
329 stars 22 forks source link

Create native XInput implementation #78

Open rebtd7 opened 2 years ago

rebtd7 commented 2 years ago

Should hopefully fix the issue where some users would get incorrect controller mapping/spinning camera.

https://steamcommunity.com/app/292120/discussions/0/4312743731808007161/ https://steamcommunity.com/app/292120/discussions/0/613938693134914508/ https://steamcommunity.com/app/292120/discussions/0/3047230236583754130/ https://steamcommunity.com/app/292120/discussions/1/3047231300180681161/ https://steamcommunity.com/app/292120/discussions/0/141136086923284332/

Also allows hotswapping controllers without any slowdown, and fixes two issues with vibration:

  1. High/Low frequency vibration variables were swapped (probably the real cause of https://github.com/rebtd7/FF13Fix/issues/24, the motor used the most by the game is the strongest one and we were incorrectly using the weaker one)

  2. Vibration was not working after hotswapping

Vibration also now runs in the main thread (should be more accurate)

rebtd7 commented 2 years ago

@Nucleoprotein Are you okay? Would you like to review this?

illum1nerdi commented 2 years ago

Is this PR still under review? This would fix a rather large issue with the game. Thanks