rebus-org / Rebus.Autofac

:bus: Autofac container adapter for Rebus
https://mookid.dk/category/rebus
Other
12 stars 11 forks source link

issue #14 https://github.com/rebus-org/Rebus.Autofac/issues/14 #16

Closed leomenca closed 4 years ago

leomenca commented 4 years ago

Hi @mookid8000, this is the solution for issue #14 I also need the opportunity to register rebus in a child lifetime scope. (In that case registerbuildcallback doesn't help)

I hope you will apreciate this.

Leonardo

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

mookid8000 commented 4 years ago

Hi @leomenca , that's really good news! 😁 could you go and accept the CLA? Then I'll merge your PR right away

leomenca commented 4 years ago

@mookid8000 Signed the CLA

leomenca commented 4 years ago

Hello @mookid8000 , I'am new on GiutHub.I have signed CLA, now PR needs another push to close? Thank you.

mookid8000 commented 4 years ago

Aah, I know what's missing 🙂 you've made the commits using an email address unknown to GitHub! Check this out – here are your commits:

image

If GitHub knows the email address embedded in the commits, it will render your name as a link to your GitHub profile. This is also the information used by the CLA assistant to link your user account and your commits together.

The solution is to go to your GitHub settings under the "Emails" panel, and add the email address as one of your email addresses. When you do that, everything will work 😄

leomenca commented 4 years ago

Aah, I know what's missing 🙂 you've made the commits using an email address unknown to GitHub! Check this out – here are your commits:

image

If GitHub knows the email address embedded in the commits, it will render your name as a link to your GitHub profile. This is also the information used by the CLA assistant to link your user account and your commits together.

The solution is to go to your GitHub settings under the "Emails" panel, and add the email address as one of your email addresses. When you do that, everything will work 😄

Hi @mookid8000 . Now my GitHub account seems linked to the primary mail. My last commit leomenca@250b2dc19bd9441fa2ef6d96fad6bc2a05b061d9 redirects to my own profile. But Cla still doesn't work. I tried to resign but nothing. I think something is stuck.

leomenca commented 4 years ago

image

mookid8000 commented 4 years ago

Your first two commits are made using the email address leonardo.mencarini@outlook.it, which appears to be unknown to GitHub.

Your other email address, leonardo.mencarini@gmail.com, is known as you can see:

image

Solution: Go add leonardo.mencarini@outlook.it as an additional email address in Settings/Emails.

mookid8000 commented 4 years ago

It's "Settings"

image

and then it's "Emails", and then "Add email address":

image

leomenca commented 4 years ago

Thanks a lot!!!

mookid8000 commented 4 years ago

No, thank you! 😄

Your fix is out in Rebus.Autofac 6.0.0-b09 on NuGet.org now.