Closed asleire closed 4 years ago
I wasn't sure whether to create the interface ICloudQueueFactory
or simply use a Func<string,Task<CloudQueue>>
. A Func
would've been easier to use, but I still feel like an interface is the neater way to go.
Ah, neat!
One thing though: I think it would be more Rebus-like to pull the required ICloudQueueFactory
from Rebus' configuration container ("injectionist").
I'll add a few inline comments... just a sec
Cool, thanks! 👍 your contribution is out as Rebus.AzureQueues 0.4.0 on NuGet.org now 😄
Awesome, thanks!
Fixes #1
Public changes:
ICloudQueueFactory
which has the purpose of providing instances ofCloudQueue
AzureStorageQueuesTransport
whichICloudQueueFactory
as a parameter instead ofCloudStorageAccount
StandardConfigurer<ITransport>
which takeICloudQueueFactory
as a parameterInternal changes:
AzureStorageQueuesTransport
to useICloudQueueFactory
internally instead of aCloudStorageAccount
CloudQueueClientQueueFactory
which implementsICloudQueueFactory
using an instance ofCloudQueueClient
(which is provided byCloudStorageAccount
)No breaking changes