rebus-org / Rebus.AzureServiceBus

:bus: Azure Service Bus transport for Rebus
https://mookid.dk/category/rebus
Other
33 stars 20 forks source link

This resolves #30, shared access policy with manage permission is always required #31

Closed ehabelgindy closed 5 years ago

ehabelgindy commented 5 years ago

where a shared access policy with a manage permission is no longer required if the queue is already created.


Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mookid8000 commented 5 years ago

Excellent work!! 👍 let me see if I can find the time and energy to click that green button above.....

mookid8000 commented 5 years ago

just a moment...... let me see...

mookid8000 commented 5 years ago

mouse pointer getting nearer..........

mookid8000 commented 5 years ago

almost there....

mookid8000 commented 5 years ago

CLICK!

mookid8000 commented 5 years ago

PS: Thanks for fixing this – it was a pretty nice and well-rounded pull request, only thing missing was the text

– thanks ehabelgindy

in the changelog 😉

mookid8000 commented 5 years ago

it'll be out in Rebus.AzureServiceBus 6.0.7 in a few minutes

ehabelgindy commented 5 years ago

@mookid8000 glad you managed to find the green button :) Really happy to contribute to the repo, and please keep up the excellent work. One more thing, thanks very much for the fast response.