search

rebus-org / Rebus.AzureServiceBus

:bus: Azure Service Bus transport for Rebus
https://mookid.dk/category/rebus
Other
33 stars 20 forks source link

Added SagaStorage implementation using TableStorage #71

Closed kristofdegrave closed 3 years ago

kristofdegrave commented 3 years ago

Added a SagaStorage implementation using TableStorage.

Currently it stil uses a pre-release version of Azure.Data.Tables (12.0.0-beta.7) because of an issue in the Delete and DeleteEntity in the TableClient. (https://github.com/Azure/azure-sdk-for-net/issues/21458)

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

mookid8000 commented 3 years ago

Hi @kristofdegrave , sorry for taking so long to get back to you!

It's super neat, and I have got very few comments about it.

I do think it's in the wrong place, though, as this is the Rebus+AzureServiceBus repository.

As you can see here, Rebus' repositories/packages are organized by dependency

image

and so it would be most appropriate if I create a new repository for this.

If that's alright with you, then I'll go and set it up, and then you can port your contribution over there – how does that sound? 🙂

mookid8000 commented 3 years ago

OK i've set it up already – here it is 👉 https://github.com/rebus-org/Rebus.AzureTables

kristofdegrave commented 3 years ago

Hi, Tnx for setting it up. I'll add the necessary code there.

I was also doubting to put the code here for the same reasons, but a PR makes it more visible then adding a complete new repository.