search

rebus-org / Rebus.CastleWindsor

:x: DEPRECATED :bus: Castle Windsor container adapter for Rebus
https://mookid.dk/category/rebus
Other
2 stars 2 forks source link

Update to Rebus Version 6.0.0-B04 and Castle.Windsor Version 5.0.0 #3

Closed nativenolde closed 5 years ago

nativenolde commented 5 years ago

@mookid8000 Hey mogens,

i tried to update the library to Castle Windsor version 5 and Rebus version 6… Unfortunately there is no 'Rebus.Tests.Contracts' package version 6, which is required to complete the update. Please feel free to pick up this PR and to update the package.

Sincerely,

nolde

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

mookid8000 commented 5 years ago

Is it necessary to update the Rebus reference to 6?

nativenolde commented 5 years ago

Is it necessary to update the Rebus reference to 6?

Im not 100% sure, but after i ran into obvious failures because of changed namespaces, i thought there could be more detailed failures which are not showing up yet…

This is one of the libraries i use, therefore i wanted to be safe. If you think it's not necessary, this could be withdrawn of course.

nativenolde commented 5 years ago

It seems to work without updating rebus to version 6, my concern was unfounded, so this pull request is not required.

mookid8000 commented 5 years ago

Perfect! It's what I expected, but it's good to have it verified 😄