search

rebus-org / Rebus.Microsoft.Extensions.Logging

:bus: Microsoft Logging Extensions integration for Rebus
https://mookid.dk/category/rebus
Other
3 stars 7 forks source link

net6 support for Rebus.Microsoft.Extensions.Logging #9

Closed dannythunder closed 1 year ago

dannythunder commented 2 years ago

Got conflicts when using

Add support for net6 in Rebus.Microsoft.Extensions.Logging. Add support for Microsoft.Extensions.Logging v6 (low) in Rebus.Microsoft.Extensions.Logging

PR: Pull req

mookid8000 commented 2 years ago

Cool cool, but what do you accomplish by adding .NET Standard 2.1, .NET 5, and .NET 6 as additional targets?

What do you mean by "got conflicts when using"?

dannythunder commented 2 years ago

@mookid8000 I redid the PR. The first was based on the 3.0.0 branch, redid it and based it on master.

Thats why there was additional targets.

conflicts as in warnings, my bad.

A bit late... 🙄

mookid8000 commented 2 years ago

It still looks like the Rebus.Microsoft.Extensions.Logging project is targeting .NET 6.

Could you make it .NET Standard 2.0 instead?

dannythunder commented 1 year ago

Fixed

dannythunder commented 1 year ago

@mookid8000 I see that the code is in master, but I cant't see a new nuget for this. Do you have to trigger it manually? And this issue can be closed after the nuget package is created.

mookid8000 commented 1 year ago

Oh, damn! And yes, the release process is something that needs to be manually triggered.

I did it now though 🙂 with some other changes that seemed necessary - let me know if it works as it should!