ActivityTagsCollection "The collection already contains item with same key 'xxxx''" - Githubissues

rebus-org / Rebus.OpenTelemetry

Other

12 stars 3 forks source link

ActivityTagsCollection "The collection already contains item with same key 'xxxx''" #17

Closed pfab-io closed 5 months ago

pfab-io commented 7 months ago

When an activity tag already exists, there's an System.InvalidOperationException: "The collection already contains item with same key 'xxxx''"

checking source code it seems that activity tags are added without checking if they are already present

maybe i'm using OpenTelemetry in the wrong way, but this is blocking because the exception is stopping the main thread of the message

in my case this happens when all the retries of the messages fail and Rebus is preparing to send an IFailed<>

basically since i've added Rebus.OpenTelemetry my app has stopped to receive IFailed<>

pfab-io commented 2 months ago

hello, any news to have a new stable or alpha nuget package with this fix?

latest version is still 1.0.0 (8 monthos ago) and we are blocked to send rebus opentelemetry data to app insights

zlepper commented 2 months ago

@mookid8000 Can you make a release? :)

mookid8000 commented 2 months ago

Yes, sorry! I Didn't realize that there was unreleased stuff in here 😅

It's out as Rebus.OpenTelemetry 1.0.1 on NuGet.org now!

THanks for waking me up from my slumber 🙂