search

rebus-org / Rebus.OpenTelemetry

Other
12 stars 4 forks source link

The process activity has the same kind as the parent (receive) activity #7

Closed michielvoo closed 2 years ago

michielvoo commented 2 years ago

I noticed that for incoming messages there are 2 activities started, one with a name that ends with receive, and another one with a name that ends with process. But on this line the activity kind of the process activity is set to the same kind of its parent (receive) activity (e.g. ActivityKind.Server when it's a command message, or ActivityKind.Consumer when it is an event message).

But I believe this is not correct, and that it should actually be set to ActivityKind.Internal, which according to the documentation indicates an:

Internal operation within an application, as opposed to operations with remote parents or children.

zlepper commented 2 years ago

Apparently i have push access.... @mookid8000 Maybe you should set the branch protection so we can't accidently push to master?

zlepper commented 2 years ago

Also, problem should be fixed, so might want to make a new build?

michielvoo commented 2 years ago

Also, problem should be fixed, so might want to make a new build?

Yes please :-)

@zlepper Thank you very much for fixing this so quickly!

mookid8000 commented 2 years ago

Cool 🙂 I've release your fix as Rebus.Diagnostics 0.0.4 and Rebus.OpenTelemetry 0.0.4, available on NuGet.org now

And regarding your push rights @zlepper , I actually think it's nice that you can do it, because then you can make changes without necessarily requiring me to be there. 😁