rebus-org / Rebus.PostgreSql

:bus: PostgreSQL persistence for Rebus
https://mookid.dk/category/rebus
Other
17 stars 19 forks source link

Saga serialization configuration ignores the custom serialize settings #40

Closed mfahadi closed 1 year ago

mfahadi commented 1 year ago
s.UseSagaSerializer(new JsonSagaSerializer(new JsonSerializerSettings()
{
    TypeNameHandling = TypeNameHandling.None
}));

Above settings has no affect on serialization of sagas, I believe the culprit is below line and should be used like c.Has<ISagaSerializer>(false), same as Sql Server implementation.

https://github.com/rebus-org/Rebus.PostgreSql/blob/b5b33b10a1c198cb09c2613ebe95a481453f22b4/Rebus.PostgreSql/Config/PostgreSqlConfigurationExtensions.cs#L68

Link to the usuage in Sql Server repo

A related question, should not we use System.Text.Json serializer as default as it is used for transport.

mookid8000 commented 1 year ago

Fixed by you @mfahadi in #42 - out in Rebus.PostgreSql 9.0.0-alpha05 on NuGet.org now 🙂 thanks again!

mfahadi commented 1 year ago

@mookid8000 thanks for the quick merge :)