micdah
commented
9 months ago Looks like ConnectionFactory handles this explicitly, by taking the 2nd segment thus skipping the / which is the first segment:
private void SetUri(Uri uri)
{
Endpoint = new AmqpTcpEndpoint();
if (string.Equals("amqp", uri.Scheme, StringComparison.OrdinalIgnoreCase))
{
// nothing special to do
}
else if (string.Equals("amqps", uri.Scheme, StringComparison.OrdinalIgnoreCase))
{
Ssl.Enabled = true;
Ssl.Version = AmqpUriSslProtocols;
Ssl.AcceptablePolicyErrors = SslPolicyErrors.RemoteCertificateNameMismatch;
Port = AmqpTcpEndpoint.DefaultAmqpSslPort;
}
else
{
throw new ArgumentException($"Wrong scheme in AMQP URI: {uri.Scheme}");
}
string host = uri.Host;
if (!string.IsNullOrEmpty(host))
{
HostName = host;
}
Ssl.ServerName = HostName;
int port = uri.Port;
if (port != -1)
{
Port = port;
}
string userInfo = uri.UserInfo;
if (!string.IsNullOrEmpty(userInfo))
{
string[] userPass = userInfo.Split(':');
if (userPass.Length > 2)
{
throw new ArgumentException($"Bad user info in AMQP URI: {userInfo}");
}
UserName = UriDecode(userPass[0]);
if (userPass.Length == 2)
{
Password = UriDecode(userPass[1]);
}
}
/* C# automatically changes URIs into a canonical form
that has at least the path segment "/". */
if (uri.Segments.Length > 2)
{
throw new ArgumentException($"Multiple segments in path of AMQP URI: {string.Join(", ", uri.Segments)}");
}
if (uri.Segments.Length == 2)
{
VirtualHost = UriDecode(uri.Segments[1]);
}
_uri = uri;
}
EraYaN
ldeluigi
mksergiy
mookid8000
Looks like an unintended bug might have been introduced by this commit: https://github.com/rebus-org/Rebus.RabbitMq/commit/96eead68ef808a852feff2ced51c1e15bd7f0f1b
From the looks of it, this change means any vhost must begin with a
/, becauseuri.LocalPathwill have the leading/included, so if I have a URIamqp://foo:bar@1.2.3.4/vhostthenLocalPathlooks like it will be/vhost, and previously when passing the entire Uri, RabbitMQ (correctly) interpreted the vhost to bevhostnot/vhostSadly this seems to have just broken our production environment, so I am hastenly trying to rollback our updated 🔥