search

rebus-org / Rebus.RabbitMq

:bus: RabbitMQ transport for Rebus
https://mookid.dk/category/rebus
Other
63 stars 44 forks source link

Added functionality to automatically restore deleted queues and their subscriptions #27

Closed pjh1974 closed 5 years ago

pjh1974 commented 5 years ago

@mookid8000 This PR is related to an issue I raised earlier. This is the best solution that I have found, I can't think of any side-effects that it will cause but in my particular case solves the problem perfectly.

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mookid8000 commented 5 years ago

Cool! Could you maybe go click the CLA thing above, so I can accept your pull request?

pjh1974 commented 5 years ago

@mookid8000 I've already clicked the CLA think several times, it says thank you for signing the CLA and sends me back to GitHub but it seems GitHub is not detecting the signature from the CLA assistant. I've just tried it again and it's still doing the same thing.

mookid8000 commented 5 years ago

I think it's because your commits have been made with an email address unknown to GitHub. This also shows because your name "Peter Holmes" on the commits is not clickable.

Under your GitHub user account, you can add several email addresses, so you should probably go and add yours there.

pjh1974 commented 5 years ago

@mookid8000 Finally sorted it. Thanks.

mookid8000 commented 5 years ago

Perfect 😁

mookid8000 commented 5 years ago

it'll be out in 5.0.0-b02 in a few minutes

pjh1974 commented 5 years ago

Thanks @mookid8000, I had to add my work email address. I think it is because I use my work email address for the Git client, but my personal email address for GitHub.