search

rebus-org / Rebus.RabbitMq

:bus: RabbitMQ transport for Rebus
https://mookid.dk/category/rebus
Other
63 stars 44 forks source link

Better performance on publisher confirms in transaction #40

Closed kyrrem closed 5 years ago

kyrrem commented 5 years ago

When sending multiple messages in a rebus transaction, it takes a lot of time to confirm each message individually. Since we are reusing the same IModel from the current transaction, it should be safe to confirm all messages in one go. The performance difference when running inside a rebus transaction is huge.

Batch confirms is also recommended from the RabbitMQ webside due to performance and latency.

I extended the current performance tests to also run in transaction to be able to compare side by side.

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mookid8000 commented 5 years ago

Perfect! Great work, thanks 👍

mookid8000 commented 5 years ago

it'll be out in Rebus.RabbitMq 5.0.1 in a few minutes