search

rebus-org / Rebus.RabbitMq

:bus: RabbitMQ transport for Rebus
https://mookid.dk/category/rebus
Other
63 stars 44 forks source link

Support adding `clientProvidedName` to Rabbit's ConnectionFactory #52

Closed hulvei3 closed 4 years ago

hulvei3 commented 5 years ago

For debugging purposes, it would be nice to have the option to "label" the connections created with Rebus. This is supported through rabbitmq client and could be defaulted to the assembly or namespace - or not.

This properly fits directly into the ConnectionManager unless there's a better way of grouping the properties to rabbit

mookid8000 commented 5 years ago

Sorry for closing... I thought I had the answer, but I was too quick there.

That would indeed be a nice feature 😄

Defaulting to the entry assembly or something similar would definitely be neat. It could then be customized in the same way as client properties are configured (did you know that that was possible?)

hulvei3 commented 5 years ago

Yes, that would be a natural place to put it. Let me see if I cannot find time to make a PR within the next days..

jarikp commented 4 years ago

hi @hulvei3 , you can achieve that by decorating the connection factory, as it's shown in my PR. /Jarik

mookid8000 commented 4 years ago

Note to future self or someone else: When RabbitMq.Client 6 is released, this can be easily solved. 🙂

hulvei3 commented 4 years ago

Actually, I solved this by using .ClientConnectionName(..) on the RMQ configurer object. Not sure why I missed that a year ago. Maybe it was added afterwards.

Will anyway close this issue.