search

rebus-org / Rebus.RabbitMq

:bus: RabbitMQ transport for Rebus
https://mookid.dk/category/rebus
Other
63 stars 44 forks source link

incorrect implementation of RabbitMqQueueOptionsBuilder.SetAutoDelete() and ClientConnectionName(string connectionName) to RabbitMqOptionsBuilder to propogate the connection_name property #58

Closed jarikp closed 4 years ago

jarikp commented 4 years ago

Corrected error in RabbitMqQueueOptionsBuilder.SetAutoDelete(): it was impossible to configure QueueTTL unless autoDelete is ON, and those are completely independent parameters in RMQ.

The original version cannot be used to setting queue TTL and not enabling autoDelete at the same time. To workaround one had to disable auto-delete through SetAutoDelete() and set queue TTL as AddArgument("x-expires",TTL_MS).

I belive, it will fix issue 55

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

jarikp commented 4 years ago

The second commit could work as temporary fix for Issue 52, until version 6 of RMQ client is released:

image

mookid8000 commented 4 years ago

cool! it'll be out in Rebus.RabbitMq 5.1.3 in a few minutes when the ci server finishes munching through the tests