search

rebus-org / Rebus.RabbitMq

:bus: RabbitMQ transport for Rebus
https://mookid.dk/category/rebus
Other
63 stars 44 forks source link

rabbitmq-dotnet-client 6.1 crashes rebus at startup #69

Closed mathiasnohall closed 3 years ago

mathiasnohall commented 4 years ago

using the new version of dotnet rabbitMQ client 6.1.0 seems to make rebus crash at startup in an MVC ASPNET Core 3.1 application.

Rebus.Injection.ResolutionException: 'Could not resolve Rebus.RabbitMq.RabbitMqTransport with decorator depth 0 - registrations: Rebus.Injection.Injectionist+Handler'

TypeLoadException: Could not load type 'RabbitMQ.Client.IQueueingBasicConsumer' from assembly 'RabbitMQ.Client, Version=6.0.0.0, Culture=neutral, PublicKeyToken=89e7d7c5feba84ce'.

using Rebus 6.3.0 and Rebus.RabbitMq 7.1.0

mookid8000 commented 4 years ago

Sounds like Rebus.RabbitMq needs to have its RabbitMq.Client dependency updated.

mookid8000 commented 4 years ago

OK, work is ongoing in making Rebus.RabbitMq work with version 6.1 of the driver.

Many of the tests are passing now, but some of them experience weird errors that indicates having received some kind of mangled message body.

Gonna park it for now – most recent code is on master.

Ilya-by commented 3 years ago

Gonna park it for now

any news on updating the client driver version?

mookid8000 commented 3 years ago

oh, it's been a long time since I've looked at it.... I'll see if I can get back to this in the coming week

archimate commented 3 years ago

waiting。。。

wzychla commented 3 years ago

Bumping this.

mathiasnohall commented 3 years ago

https://github.com/rebus-org/Rebus.RabbitMq/pull/71

solves this. I have tested it in our code enviroment and it works. Some unit tests in Rebus.RabbitMq.Tests are failing though

mookid8000 commented 3 years ago

Ok cool! I'll have time to look at it on Friday

mathiasnohall commented 3 years ago

ok there seem to be some issue with the internal queue in CustomQueueingConsumer.cs. If I change it from a ConcurrentQueue to the old SharedQueue from https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/5.x/projects/client/RabbitMQ.Client/src/util/SharedQueue.cs it seems to work better. Only 1 test is failing now..

mookid8000 commented 3 years ago

Should be fixed by #71 🙂