search

rebus-org / Rebus.RabbitMq

:bus: RabbitMQ transport for Rebus
https://mookid.dk/category/rebus
Other
62 stars 44 forks source link

Updating to make net 5.0 work #75

Closed renemadsen closed 3 years ago

renemadsen commented 3 years ago

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: renemadsen
:x: dependabot-preview[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

mookid8000 commented 3 years ago

Hi again @renemadsen , I really appreciate this! But is there any chance you could squash your commits? I'd like to avoid incorporating commits from @dependabot-preview because it's not a human... 😁

Btw. I there's a thing I've been wondering about: I see you added .NET Standard 2.0, .NET Standard 2.1, and .NET 5.0 as build targets.

What is the purpose of .NET Standard 2.1 in this case? Wouldn't you say that packages that aren't capable of leveraging .NET Standard 2.1 stuff (Span<T>, IAsyncEnumerable, ...) should target .NET Standard 2.0 (for broadest possible reach) .. and what is the purpose of targeting .NET 5.0 even? If I understand things correctly, using the .NET 5.0 runtime would bring performance improvements about, even when the code running is .NET Standard 2.0... do you know anything about this?

renemadsen commented 3 years ago

Hi again @renemadsen , I really appreciate this! But is there any chance you could squash your commits? I'd like to avoid incorporating commits from @dependabot-preview because it's not a human...

Yes, I can do that, but do consider using dependabot on your projects, since it makes the life of keeping projects up to date so much easier, when you have a lot of repositories to maintain and it's only updating dependencies.

Btw. I there's a thing I've been wondering about: I see you added .NET Standard 2.0, .NET Standard 2.1, and .NET 5.0 as build targets.

What is the purpose of .NET Standard 2.1 in this case? Wouldn't you say that packages that aren't capable of leveraging .NET Standard 2.1 stuff (Span<T>, IAsyncEnumerable, ...) should target .NET Standard 2.0 (for broadest possible reach) .. and what is the purpose of targeting .NET 5.0 even? If I understand things correctly, using the .NET 5.0 runtime would bring performance improvements about, even when the code running is .NET Standard 2.0... do you know anything about this?

I'll do some testing in that regard, since I actually don't really know. So probably you are right about setting it to netstandard2.0 would be enough.