search

rebus-org / Rebus.ServiceProvider

:bus: Microsoft Extensions Dependency Injection container adapter for Rebus
https://mookid.dk/category/rebus
Other
65 stars 32 forks source link

Request: Split this package in two: Rebus.ServiceProvider and Rebus.AspNetCore #14

Closed alexdrl closed 5 years ago

alexdrl commented 6 years ago

Hello, we are using this package in a Xamarin application, and seeing that the ASP.NET Core hosting DLLs are loading into the Xamarin app because the dependency in Rebus.ServiceProvider.

The Xamarin app only uses de AddRebus method.

Could this be split in two packages? With some guidance, we could help with that.

larsw commented 6 years ago

Hi,

I agree with @alexdrl - it would be nice if this package was split into two; it pulls in AspNetCore dependencies when they're not needed.

mookid8000 commented 6 years ago

Is there any reason why this package should have a dependency on ASP.NET Core at all?

larsw commented 6 years ago

No, not really. IMHO it should only depend on Microsoft.Extensions.DependencyInjection and Rebus.

mookid8000 commented 6 years ago

well, I guess that's pretty easy then.... 😄

Hawxy commented 5 years ago

@mookid8000 any plans to update this package?

Edit: I'm working on a PR for this.

mookid8000 commented 5 years ago

@Hawxy 👍