Closed Hawxy closed 5 years ago
Excellent work 👍
One thing though: The buildserver says it's good, but it turned out it's because it didn't run the tests (don't know why...)
When I run the tests I get this result:
I understand that it's because the container adapter does not get disposed as required, but my knowledge of the Microsoft Extensions DI container is not sufficient to understand how it's supposed to work.
How would one usually ensure that disposing the container would dispose something in it?
My bad, I forgot to re-run those tests before PR'ing. I'll take a look.
Edit: Interesting, I can get the RealContainerTests to pass but not the ContainerTests
See #18
Fixes #14
Breaking changes:
app.UseRebus()
->app.ApplicationServices.UseRebus()
Notes:
Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.