search

rebus-org / Rebus.ServiceProvider

:bus: Microsoft Extensions Dependency Injection container adapter for Rebus
https://mookid.dk/category/rebus
Other
68 stars 32 forks source link

Unnecessary dependency on Microsoft.Extensions.DependencyInjection #34

Closed jorenp closed 4 years ago

jorenp commented 4 years ago

Not really a bug, but a possible improvement. The existing dependency on Microsoft.Extensions.DependencyInjection could be replaced by Microsoft.Extensions.DependencyInjection.Abstractions.

The only usage of a type from this package is in ServiceCollectionExtensions.Handlers and the signatures can be modified to use IServiceCollection. image

If welcome, I can create a PR for the change.

mookid8000 commented 4 years ago

Great idea! PR is most welcome 🙂

mookid8000 commented 4 years ago

fixed in Rebus.ServiceProvider 5.0.6