search

rebus-org / Rebus.SqlServer

:bus: Microsoft SQL Server transport and persistence for Rebus
https://mookid.dk/category/rebus
Other
43 stars 42 forks source link

Should `SqlServerTransport` use `ConfigureAwait(false)` ? #30

Closed MrMDavidson closed 5 years ago

MrMDavidson commented 6 years ago

Just looking through some of the code in Rebus.Sqlserver. I know in Rebus core's ThreadPoolWorker that it's using ConfigureAwait(false) for all it's async operations. However I notice that in SqlServerTransport (and the lease transport, too, I guess) this isn't the case.

Eg. https://github.com/rebus-org/Rebus.SqlServer/blob/db455fcca9ff7317a8169276250c7c35812b6f7f/Rebus.SqlServer/SqlServer/Transport/SqlServerTransport.cs#L288

Is there a reason why this isn't using ConfigureAwait(false) ?

mookid8000 commented 6 years ago

Is there a reason why this isn't using ConfigureAwait(false)?

No 😄

It probably should.

MrMDavidson commented 6 years ago

Okay, just wanted to check there wasn't some big underlying reason for it before I looked into it further!

mookid8000 commented 5 years ago

Fixed in 5.0.0-b7 😄