rebus-org / Rebus.SqlServer

:bus: Microsoft SQL Server transport and persistence for Rebus
https://mookid.dk/category/rebus
Other
43 stars 44 forks source link

Faulty DbConnectionFactoryProvider? #72

Closed pi3k14 closed 4 years ago

pi3k14 commented 4 years ago

Can't see that the documentation and implementation of https://github.com/rebus-org/Rebus.SqlServer/blob/master/Rebus.SqlServer/SqlServer/DbConnectionFactoryProvider.cs is in sync.

Is this class used under these assumptions in the code, and should be improved, or are this just leftovers from a copy of DbConnectionProvider that should be removed?

mookid8000 commented 4 years ago

Ah I see! Thanks for pointing it out 🙂 I've fixed it in Rebus.SqlServer 7.1.3