search

rebus-org / Rebus

:bus: Simple and lean service bus implementation for .NET
https://mookid.dk/category/rebus
Other
2.26k stars 353 forks source link

fix(Retry): do not create nested scope for ErrorHandler in DefaultRetryStep #1155

Closed AndreaCuneo closed 2 months ago

AndreaCuneo commented 3 months ago

ErrorHandler impl should create their own nested scope when needed.

Update the DeadletterQueueErrorHandler accordling.

fix: #1127

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

AndreaCuneo commented 3 months ago

@hjalle @mookid8000 I did not reproduced the ASB integration error after this change and not plan to. I checked the Rebus.ASB code and my 👀 are convinced that it will work. Another pair of 👀 would be great to double check nonetheless.

mookid8000 commented 2 months ago

Your PR is out as Rebus 8.3.0 on NuGet org now! 🙂