search

rebus-org / Rebus

:bus: Simple and lean service bus implementation for .NET
https://mookid.dk/category/rebus
Other
2.31k stars 359 forks source link

Add FlattenHierarchy binding flag in ActivateHandlersStep::GetDispatchMethod #1173

Closed X509Whatever closed 3 weeks ago

X509Whatever commented 3 weeks ago

Hi!

The class ActivateHandlersStep has the method CreateHandlerInvoker marked as virtual (useful++).

Trying to override it, I noticed in runtime that the method to make GetHandlerInvokers as generic method was failing because wasn't found.

image

It could be great if it includes the binding flag flatten hierarchy so that when we extend this class we don't have to copy this method again (being able to use the original one).

Regards

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

mookid8000 commented 3 weeks ago

A small, but pretty excellent improvement 😎 thanks! It's out in Rebus 8.4.4 on NuGet.org now