rebus-org / Rebus

:bus: Simple and lean service bus implementation for .NET
https://mookid.dk/category/rebus
Other
2.3k stars 358 forks source link

Azure Service Bus serialization interop support #349

Closed Meyce closed 8 years ago

Meyce commented 8 years ago

Use Streams for the ser/deserialization of the TransportMessage to BrokeredMessage and vice versa. This will improve the interop support between different platforms/languages. NServiceBus has a similar issue due to the usage of BrokeredMessage. See the referenced link for more detail.

https://github.com/Particular/NServiceBus.AzureServiceBus/issues/49

I've cloned the repo and made an update to the AzureServiceBusTransport and switching to Streams works fine, but making a change would have impact to production systems. If you have any thoughts on how to work around this please let me know.

mookid8000 commented 8 years ago

PR as fast as you can ;)

no, seriously - Rebus2 has not stabilized so much yet that I see this as a problem, so I will happily accept your pull request right away!

Meyce commented 8 years ago

I'll try to get a PR done this afternoon.

On Mon, Oct 5, 2015 at 11:34 PM, Craig Meyer meyer.craig.e@gmail.com wrote:

On Monday, October 5, 2015, Mogens Heller Grabe notifications@github.com wrote:

PR as fast as you can ;)

no, seriously - Rebus2 has not stabilized so much yet that I see this as a problem, so I will happily accept your pull request right away!

— Reply to this email directly or view it on GitHub https://github.com/rebus-org/Rebus/issues/349#issuecomment-145673458.

Sent from Gmail Mobile

mookid8000 commented 8 years ago

:+1: :smiley:

Meyce commented 8 years ago

I'm getting a 403 trying to publish a branch with the changes.

On Tue, Oct 6, 2015 at 8:16 AM, Mogens Heller Grabe < notifications@github.com> wrote:

[image: :+1:] [image: :smiley:]

— Reply to this email directly or view it on GitHub https://github.com/rebus-org/Rebus/issues/349#issuecomment-145839374.

mookid8000 commented 8 years ago

Did you fork the repository?

Meyce commented 8 years ago

No I branched. I'll fork it. Sorry, first time contributing.

mookid8000 commented 8 years ago

no problem :) let me know if you need any more assistance

Meyce commented 8 years ago

Will do.

Meyce commented 8 years ago

update released in 99.