search

rebus-org / Topper

:tophat: Simple Windows Service helper (Topshelf-based, Azure Web Job capable)
Other
28 stars 4 forks source link

updated nuget package #4

Closed mpaul31 closed 6 years ago

mpaul31 commented 6 years ago

Rebus is MIT-licensed. The code submitted in this pull request needs to carry the MIT license too. By leaving this text in, I hereby acknowledge that the code submitted in the pull request has the MIT license and can be merged with the Rebus codebase.

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Marco Paul seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

mookid8000 commented 6 years ago

Hi @mpaul31 , thanks for your PR 😄 there's just one thing though: If your intention was to add .NET Core support, then THIS is not how it's done 😞 Topper would need to be moved to the new csproj format so it can target .NET Standard 2

mpaul31 commented 6 years ago

ah crap. i'll see if i get a chance in the coming days to go through the document and figure out what all i need to change. thanks for the heads up

mookid8000 commented 6 years ago

Hi dude, I'll close this one for now... please do a new PR if you convert it to the new project format.

Maybe you can get some inspiration from one of the Rebus projects? For example the Rebus.Async project is pretty simple.