fix: skip kms keys if describe is disallowed

rebuy-de / aws-nuke

Nuke a whole AWS account and delete all its resources.

https://github.com/ekristen/aws-nuke

MIT License

5.77k stars 725 forks source link

fix: skip kms keys if describe is disallowed #1248

Closed mKeRix closed 2 months ago

mKeRix commented 4 months ago

We noticed that aws-nuke will abort listing KMS keys if it does not have permissions to read one of them, which means that a single key with a key policy that does not allow reading is all it takes for all keys to not be nuked anymore. This change updates the behavior so that these keys will be skipped, allowing other keys to still be nuked. This is done because it can be intentional that some keys will not be readable by their key policy, and aws-nuke should be able to handle that.

ekristen commented 2 months ago

@mKeRix this has been implemented via https://github.com/ekristen/aws-nuke/pull/260 - this is now the active fork of aws-nuke.

This project has now been deprecated in favor of this fork. Sven kindly granted me access to directly answer and close pull requests and issues so that we can notify users if their issues have been addressed or not. Please see the welcome issue for more information.