rebuy-de / node-drainer

Reads AWS autoscaling group lifecycle events, triggers Kubernetes node draining and notifies AWS upon completion.
MIT License
9 stars 3 forks source link

New vault support breaks the tool #81

Open bruecktech opened 3 years ago

bruecktech commented 3 years ago

Hello,

the latest commit to master broke the tool for us. It errors out on startup with this message shown below.

Could you please have a look?

Thank you!

time="2021-04-30T05:51:42Z" level=debug msg="Post \"/v1/auth/kubernetes/login\": unsupported protocol scheme \"\"\nrequest failed\ngithub.com/mittwald/vaultgo.(*Client).Request\n\t/build/vendor/github.com/mittwald/vaultgo/client.go:119\ngithub.com/mittwald/vaultgo.(*Client).Write\n\t/build/vendor/github.com/mittwald/vaultgo/client.go:158\ngithub.com/mittwald/vaultgo.kubernetesAuth.Auth\n\t/build/vendor/github.com/mittwald/vaultgo/kubernetes_auth.go:85\ngithub.com/mittwald/vaultgo.(*Client).renewToken\n\t/build/vendor/github.com/mittwald/vaultgo/client.go:89\ngithub.com/mittwald/vaultgo.NewClient\n\t/build/vendor/github.com/mittwald/vaultgo/client.go:80\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).Client\n\t/build/pkg/vaultutil/params.go:51\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSCredentialProvider\n\t/build/pkg/vaultutil/params.go:56\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSSession\n\t/build/pkg/vaultutil/params.go:69\ngithub.com/rebuy-de/node-drainer/v2/cmd.(*Runner).Run\n\t/build/cmd/runner.go:48\ngithub.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil.wrapRootConext.func1\n\t/build/vendor/github.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil/context.go:46\ngithub.com/spf13/cobra.(*Command).execute\n\t/build/vendor/github.com/spf13/cobra/command.go:856\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/build/vendor/github.com/spf13/cobra/command.go:960\ngithub.com/spf13/cobra.(*Command).Execute\n\t/build/vendor/github.com/spf13/cobra/command.go:897\nmain.main\n\t/build/main.go:12\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).Client\n\t/build/pkg/vaultutil/params.go:52\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSCredentialProvider\n\t/build/pkg/vaultutil/params.go:56\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSSession\n\t/build/pkg/vaultutil/params.go:69\ngithub.com/rebuy-de/node-drainer/v2/cmd.(*Runner).Run\n\t/build/cmd/runner.go:48\ngithub.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil.wrapRootConext.func1\n\t/build/vendor/github.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil/context.go:46\ngithub.com/spf13/cobra.(*Command).execute\n\t/build/vendor/github.com/spf13/cobra/command.go:856\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/build/vendor/github.com/spf13/cobra/command.go:960\ngithub.com/spf13/cobra.(*Command).Execute\n\t/build/vendor/github.com/spf13/cobra/command.go:897\nmain.main\n\t/build/main.go:12\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSCredentialProvider\n\t/build/pkg/vaultutil/params.go:58\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSSession\n\t/build/pkg/vaultutil/params.go:69\ngithub.com/rebuy-de/node-drainer/v2/cmd.(*Runner).Run\n\t/build/cmd/runner.go:48\ngithub.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil.wrapRootConext.func1\n\t/build/vendor/github.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil/context.go:46\ngithub.com/spf13/cobra.(*Command).execute\n\t/build/vendor/github.com/spf13/cobra/command.go:856\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/build/vendor/github.com/spf13/cobra/command.go:960\ngithub.com/spf13/cobra.(*Command).Execute\n\t/build/vendor/github.com/spf13/cobra/command.go:897\nmain.main\n\t/build/main.go:12\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371\ngithub.com/rebuy-de/node-drainer/v2/pkg/vaultutil.(*Params).AWSSession\n\t/build/pkg/vaultutil/params.go:71\ngithub.com/rebuy-de/node-drainer/v2/cmd.(*Runner).Run\n\t/build/cmd/runner.go:48\ngithub.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil.wrapRootConext.func1\n\t/build/vendor/github.com/rebuy-de/rebuy-go-sdk/v3/pkg/cmdutil/context.go:46\ngithub.com/spf13/cobra.(*Command).execute\n\t/build/vendor/github.com/spf13/cobra/command.go:856\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/build/vendor/github.com/spf13/cobra/command.go:960\ngithub.com/spf13/cobra.(*Command).Execute\n\t/build/vendor/github.com/spf13/cobra/command.go:897\nmain.main\n\t/build/main.go:12\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:225\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371"
time="2021-04-30T05:51:42Z" level=error msg="request failed: Post \"/v1/auth/kubernetes/login\": unsupported protocol scheme \"\""
bjoernhaeuser commented 3 years ago

Hi!

Sorry for that.

We will come up with a better solution to this, but for now you can use this sha256 sum to pull in the last version:

docker pull quay.io/rebuy/node-drainer@sha256:7ceb5108785e65bd5ec46a945931dcc9620437585be38f51af4e72c03eef3df0
bruecktech commented 3 years ago

Hey

no worries, thanks for the quick reply. The problem is that we need the previous sha as the current master image is broken. But the previous sha is already gone from quay.io

svenwltr commented 3 years ago

Hello.

Sorry for that. We honestly did not expect that anyone is using the node-drainer. As a hotfix I prepared a new Quay tag: quay.io/rebuy/node-drainer:d3c9fab. We will think about how to continue from here.

bruecktech commented 3 years ago

Hi,

thanks a lot for the workaround already. Totally can understand that the tool was mostly used internally :-)

svenwltr commented 3 years ago

Hello. I just merged https://github.com/rebuy-de/node-drainer/pull/83 and it should provide backwards compatibility. Nevertheless that is not tested yet and we try to tackle https://github.com/rebuy-de/node-drainer/issues/80 next week.